-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --bech32 flag to forc contract-id command #5943
Conversation
Amit Dave seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
working on updating docs. Please feel free to let me know if any areas need rework/update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A possible issue with the dependency you added, so blocking for now as I need to make sure some stuff first. If that is the case I will provide you more guidance how to move around the issue with the dependency
forc/src/cli/commands/contract_id.rs
Outdated
@@ -32,6 +32,9 @@ pub struct Command { | |||
/// Disable the "new encoding" feature | |||
#[clap(long)] | |||
pub no_encoding_v1: bool, | |||
// flag to display contract-id in bech32 format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// flag to display contract-id in bech32 format | |
// Flag to display contract-id in bech32 format |
@@ -29,6 +29,7 @@ forc-tracing = { version = "0.56.0", path = "../forc-tracing" } | |||
forc-util = { version = "0.56.0", path = "../forc-util" } | |||
fs_extra = "1.2" | |||
fuel-asm = { workspace = true } | |||
fuels-core = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency here will likely create an issue for us. Due to our internal procedures we require forc not to depend on sdk. We should be able to move around this somehow. I will think about a different way of doing this but first I wanted to make sure this is not allowed by our CI.
Also please run |
@kayagokalp I did see the fact that we are generating the documentation for all forc commands in the Sway Book by running |
Hey, no worries about that we have a mdbook preprocessor that automatically does that. So it is done via CI not manually |
Description
Closes #5842
Checklist
Breaking*
orNew Feature
labels where relevant.